Repository navigation
Enable verified SDK matching flags for the engine unit - #411
Open
MatyMeatBoy wants to merge 1 commit into
Open
MatyMeatBoy wants to merge 1 commit into
MatyMeatBoy wants to merge 1 commit into
Conversation
Select label, sign, loop and later-pool options for m4a_1_engine. Preserve normal bytes while making the ply_note draft exact in the real NONMATCHING module. Keep its ASM fallback pending its owned source conversion. Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the reviewed label, result-sign, byte-loop and later-literal-pool options for the
m4a_1_engineunit only. Compiler defaults remain off; the normal TrackStop, ply_note ASM fallback and ply_endtie bytes and relocations are unchanged.With these module rules, the real NONMATCHING ply_note C draft now matches the original 536 bytes and relocations. Keep its ASM fallback until the separately claimed source-conversion PR is delivered. This configuration change adds no matching coverage.
Validation: complete normal ROM compare OK, NONMATCHING build OK, tree zero errors, all three strict SDK oracles match. The normal engine object remains byte-identical to before activation, and the actual NONMATCHING ply_note equals the original normal ASM function under strict byte/relocation comparison. The compiler and its semantic/ABI fixtures were integrated in PR410 before this delivery.