Skip to content

test: specs for validate-required-config, configuration and IsStellarAddress - #707

Merged
chonilius merged 1 commit into
MergeFi:mainfrom
Godbrand0:fix/600-601-602-607-specs-lint
Oct 20, 2026
Merged

chonilius merged 1 commit into
MergeFi:mainfrom
Godbrand0:fix/600-601-602-607-specs-lint

Conversation

@Godbrand0

@Godbrand0 Godbrand0 commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Adds the missing unit specs:

  • validate-required-config: non-production no-op, each missing secret, insecure JWT default, default/empty DATABASE_URL, aggregated error
  • configuration: defaults, empty-string env vars, integer/boolean parsing, NaN for non-numeric PORT/ESCROW_DEADLINE_SECONDS, MAINTENANCE_POOL_CONTRACT_ID fallback
  • stellar-address validator: valid G key, bad checksum, M/C addresses, lowercase, non-strings; uses an in-spec StrKey implementation since the jest stellar-sdk mock lacks StrKey

closes #607
Closes #600
Closes #601
Closes #602

@vercel

vercel Bot commented Oct 19, 2026

Copy link
Copy Markdown

@Godbrand0 is attempting to deploy a commit to the chonilius' projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Oct 19, 2026

Copy link
Copy Markdown

@Godbrand0 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@chonilius
chonilius merged commit 11e3380 into MergeFi:main Oct 20, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants