Repository navigation
docs: document missing entrypoints and fix README inaccuracies - #718
Merged
chonilius merged 2 commits intoOct 18, 2026
Merged
Conversation
…Fi#503, MergeFi#502, MergeFi#505, MergeFi#507) - Escrow: add get_contributions, is_paused_view, set_fee_bps, set_admin, set_oracle, set_treasury to the public API table (MergeFi#502) - Milestones: add deallocate, cancel_milestone_after_deadline, keep_alive, is_paused_view, get_contributions, get_treasury, get_fee_bps, set_fee_bps, set_admin, set_oracle, recover_admin, set_treasury (MergeFi#503) - MaintenancePool: add sweep, is_paused_view, set_admin, set_oracle, recover_admin, set_treasury to the public API table (MergeFi#503) - Fix deposit_count cap: README said u32::MAX but the actual cap is MAX_DEPOSITS = 50 (to bound per-deposit iteration cost) (MergeFi#505) - Clarify backend-integration §1: view functions (get_escrow / get_milestone / get_pool) are the authoritative state source; event streaming is best-effort and subject to RPC node pruning (MergeFi#507) Closes MergeFi#507 Closes MergeFi#505 Closes MergeFi#503 Closes MergeFi#502
|
@Gbangbolaoluwagbemiga is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Gbangbolaoluwagbemiga Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four README accuracy issues fixed in a single pass:
get_contributions,is_paused_view,set_fee_bps,set_admin,set_oracle,set_treasuryto the escrow public API table.deallocate,cancel_milestone_after_deadline,keep_alive,is_paused_view,get_contributions,get_treasury,get_fee_bps,set_fee_bps,set_admin,set_oracle,recover_admin,set_treasury(milestones);sweep,is_paused_view,set_admin,set_oracle,recover_admin,set_treasury(maintenance-pool).u32::MAX" — actual cap isMAX_DEPOSITS = 50to bound iteration cost. Fixed in both the data-model comment and the Storage section prose.get_*view functions are the authoritative state source (free simulated calls); event streaming is best-effort and subject to RPC node pruning.Closes #507
Closes #505
Closes #503
Closes #502