Repository navigation
fix: multi-recipient withdraw, treasury panic guard, allocate deadline check - #729
Merged
chonilius merged 2 commits intoOct 18, 2026
Conversation
Closes MergeFi#483 Closes MergeFi#484 Closes MergeFi#486 Closes MergeFi#489
|
@Mercy017 is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Mercy017 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maintenance-pool/withdraw: replaced the inlineamount * fee_bps / BPS_DENOMINATORfee computation withmergefi_common::compute_split, matching how escrow and milestones do it.maintenance-pool/withdraw: changed signature from(pool_id, recipient: Address, amount)to(pool_id, recipients: Vec<(Address, u32)>, amount)so the oracle can pay multiple maintainers in one transaction. AddedInvalidSplitandSelfPayouterrors to the maintenance-pool error enum. All existing tests updated to pass a single 10 000-bps recipient vector.escrow/release: replacedmergefi_common::require_treasury(...).unwrap()with.ok_or(Error::NotInitialized)?so a missing treasury surfaces as a typed contract error rather than an opaque host panic.milestones/allocate: added anow >= milestone.deadlinecheck that returns the newError::DeadlinePassedbefore processing the allocation, preventing the admin from pre-empting a permissionless cancel by moving remaining budget into stranded allocations.Closes #483
Closes #484
Closes #486
Closes #489