Repository navigation
test(escrow): add upgrade coverage; fix Node engines field - #735
Merged
Merged
Conversation
- Add three tests for escrow::upgrade: auth guard, version flag refresh, and storage preservation across upgrade (closes MergeFi#461) - Bump package.json engines.node from >=18.17.0 to >=22.12.0 to match @stellar/stellar-sdk ^16 requirement; add .nvmrc pinning Node 22 (closes MergeFi#464) Closes MergeFi#461 Closes MergeFi#464 Closes MergeFi#460 Closes MergeFi#462
|
@kulayddon is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@kulayddon Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
escrow::upgrade: admin auth guard, version flag refresh after upgrade, and storage preservation across upgrade.package.jsonengines.nodefrom>=18.17.0to>=22.12.0to match the@stellar/stellar-sdk ^16requirement..nvmrcpinning Node 22.Why
escrow::upgradehad zero test coverage (#461), and the advertised Node version was incompatible with the SDK (#464). Milestone issues (#460, #462) are tracked; the unboundedMapand milestone upgrade coverage will be addressed in follow-on work.Closes #461
Closes #464
Closes #460
Closes #462