test(milestones): add set_fee_bps tests — step limit, BPS cap, auth guard

[defimomof2]

Summary

Addresses regression bounties for missing milestones::set_fee_bps test coverage.

Resolved

• [Regression on closed #243] milestones::set_fee_bps still has no test #469 — milestones::set_fee_bps still has no test

  Added 4 tests to contracts/milestones/src/test.rs:

  • test_set_fee_bps_admin_can_change_within_step_limit — admin changes fee by exactly MAX_FEE_CHANGE_BPS (500 bps); succeeds
  • test_set_fee_bps_rejects_step_exceeding_max — jump of 501 bps returns Error::InvalidFee
  • test_set_fee_bps_rejects_above_bps_denominator — value > 10 000 returns Error::InvalidFee regardless of step size
  • test_set_fee_bps_requires_admin_auth — call without admin auth mocked fails

Closes #469

To be completed

• Closes [Regression on closed #250] milestones::set_oracle still has no test #468 — milestones::set_oracle still has no test
• Closes [Regression on closed #306] escrow::initialize rejecting treasury == contract address still has no test #470 — escrow::initialize rejecting treasury == contract address
• Closes [Regression on closed #348] milestones: an existing sponsor topping up while the milestone is at the MAX_SPONSORS cap still has no test #474 — milestones: existing sponsor topping up

[vercel]

@defimomof2 is attempting to deploy a commit to the chonilius' projects Team on Vercel.

A member of the Team first needs to authorize it.

[drips-wave]

@defimomof2 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits