Repository navigation
fix: BarChart a11y focus, StatCard sparkline currency, dynamic mock feed, and Tabs aria-controls - #807
Merged
chonilius merged 1 commit intoOct 17, 2026
Conversation
…eed, and Tabs aria-controls
- Drop tabIndex={0} on BarChart visual bars inside aria-hidden container to resolve axe aria-hidden-focus violation (closes MergeFi#708)
- Pass formatValue derived from format/asset/locale to Sparkline in StatCard so currency trend values are properly announced (closes MergeFi#709)
- Dynamically compute mock activity timestamps at call/request time via getRecentActivity and dynamic proxy export so long-running servers don't show stale feeds (closes MergeFi#707)
- Omit aria-controls on inactive tabs in Tabs component to eliminate missing tabpanel reference errors (closes MergeFi#710)
|
@Prudentdev-xyz is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Prudentdev-xyz Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request resolves four accessibility and data-freshness issues across
BarChart,StatCard, mock activity feeds, andTabs:BarChart focusable elements in aria-hidden subtree (BarChart's bars are focusable (tabIndex=0) inside an aria-hidden container #708):
tabIndex={0}and focus-visible styles from visual bars inside thearia-hidden="true"container to eliminate axe'saria-hidden-focusrule violation.StatCard sparkline announcements for currency cards (StatCard's sparkline announces raw numbers (e.g. '1234.5') for currency cards #709):
formatValuederived fromformat,asset, andlocale(formatValue(v, format, asset, locale).display) intoSparkline.StatCard.tsx.Mock activity feed timestamp anchoring (Mock activity timestamps are anchored at module load, so a long-running server shows the 'live' feed hours or days stale #707):
getRecentActivity()to compute relative activity timestamps dynamically at request/call time rather than freezing them at initial module load.recentActivityso existing consumers and tests receive live timestamps regardless of how long the server process has been running.Tabs missing tabpanel ID reference (Tabs reference an inactive tab's tabpanel id that doesn't exist in the DOM #710):
Tabsto omitaria-controlson inactive tabs (aria-controls={isActive ? \tabpanel-${tab.key}` : undefined}`).Related Issues
Closes #707
Closes #708
Closes #709
Closes #710