Repository navigation
test: refuse class instances, accessors and other non-plain JS values - #15
Merged
Merged
Conversation
… in the conformance suite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The JavaScript conformance suite now checks that values which cannot cross to the host are refused at the call site: class instances,
Date, circular and too deeply nested values, and objects with getter/setter properties (the getter must not run). It also checks that a__proto__key travels as an ordinary key both ways.docs/bindings/javascript.mdstates these rules.Why
The Node marshaller already refused class instances, but the Rhino engine accepted them and ran getters during conversion. Only functions were covered by the suite, so the difference went unnoticed.
Testing
Run against the Rhino engine in MessengerBotR: it failed on class instances and getters before the engine fix and passes after. NodeJSPlugin needs a follow-up to check property descriptors before reading a property, since V8 runs the getter on
get.