Repository navigation
feat: mark the standard bot tokens as handle types - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The standard
botmodule declares its tokens with the newhandletype:replyTokenashandle<reply>,readTokenashandle<read>,imageandauthor.avatarashandle<image>, and thetokenparameter ofreply,markReadandimageto match.A provider written before this declares its tokens as
string. Sofitsaccepts astringwhere the standard has ahandle, and such providers keep working.Why
The host finds the token fields it must wrap from a hard-coded list. With the spec naming them, a later change can read the fields from the spec, so a provider that adds a token field gets the same protection without a host change.
Testing
:contract:testand:tck:testpass. New tests cover the fit rule (a string fits a handle, an int and a different kind do not) and that the standard module marks its tokens.