Repository navigation
feat: add isInjected and injectedBy to the standard message - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
bot.messagegets two optional fields the host sets:isInjected(a sandbox handed this message over instead of a messenger) andinjectedBy(the name of that sandbox). Providers leave both out, likeisDebugRoom. Both are optional, so providers and scripts built before this keep working.Why
A project cannot tell a message a sandbox injected from a real one, so a test message can make it answer into a real chat room. With the fields it can skip them.
Testing
:contract:testand:tck:testpass, with a new test for the two fields. The host side (setting, stripping provider forgeries, refusing them in sandbox input, the API2 shim) is in a MessengerBotR PR that follows.