Repository navigation
feat: add the setting tag for plugin-wide settings to the manifest schema - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
PluginManifestSchema.TAG_SETTING(<setting>), a direct child of the manifest root with the same attributes as<option>. The host reads these as settings of the whole plugin, set once in its plugin list, and adds their values toLoadRequest.optionsof every engine of that plugin.No wire change: no AIDL or protocol edits, so
BinderContract.VERSIONstays. Plugins that declare no<setting>are unaffected.Tested:
./gradlew :contract:testis unaffected by this constant; the host parser and a device test in MessengerBotR exercise it (see the MessengerBotRfeat/plugin-settingsPR).