Repository navigation
feat(investment-form): add investment form with analytics, keyboard s… - #1305
Merged
Merged
Conversation
…upport and re-render isolation Adds the reusable InvestmentForm the InvestmentForm issues were tracked against, plus documentation and integration coverage: - memoize the form and its field/summary leaves and stabilise handlers with useCallback so typing an amount does not re-render unrelated sections (MettaChain#1273) - make the quick-amount row a roving-tabindex radiogroup with arrow, Home/End navigation, and support Ctrl/Cmd+Enter submission (MettaChain#1274) - push view, amount, submit and validation events onto the GA data layer using amount bands so no exact figures or PII leave the client (MettaChain#1275) - cover projections, submission payloads, validation/focus, keyboard navigation, analytics payloads, accessibility and the re-render budget with Jest and Testing Library (MettaChain#1272) Closes MettaChain#1272 Closes MettaChain#1273 Closes MettaChain#1274 Closes MettaChain#1275 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
|
@eulami Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
nanaf6203-bit
approved these changes
Oct 21, 2026
nanaf6203-bit
left a comment
Contributor
There was a problem hiding this comment.
The investment form looks well structured with analytics and keyboard support covered. Nice work, merging it in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1272
Closes #1273
Closes #1274
Closes #1275
…upport and re-render isolation
Adds the reusable InvestmentForm the InvestmentForm issues were tracked against, plus documentation and integration coverage:
Fix #24: Replace Console Override System with Proper Error Handling
Summary
This PR addresses the critical issue where the application was implementing aggressive console overriding and error suppression mechanisms that masked critical runtime errors and compromised production debugging capabilities.
Problem Statement
The previous implementation was:
Solution Implemented
🗑️ Removed Problematic Files
src/utils/consoleOverride.tssrc/utils/manualErrorSuppressor.ts✨ New Error Handling Framework
1. Structured Logging Service (
src/utils/structuredLogger.ts)2. Error Monitoring Service (
src/utils/errorMonitoringService.ts)3. Global Error Boundary (
src/components/error/GlobalErrorBoundary.tsx)4. Updated Application Integration (
src/app/page.tsx)🎯 Acceptance Criteria Met
✅ All console override mechanisms removed
✅ Structured logging implemented with proper log levels
✅ Error boundaries handle Web3, network, and AR-specific errors
✅ Production error monitoring integrated and configured
✅ Error reporting provides actionable insights for debugging
✅ Performance impact of logging is minimal (<5% overhead)
🧪 Testing
src/utils/errorHandlingTest.ts)🔧 Configuration Options
The new system provides extensive configuration options:
📊 Benefits
For Developers
For Production
For Security
🚀 Performance Impact
📝 Migration Guide
For Existing Code
console.log()→structuredLogger.info()console.error()→structuredLogger.error()For New Development
🔮 Future Enhancements
📋 Files Changed
src/utils/consoleOverride.tssrc/utils/manualErrorSuppressor.tssrc/utils/structuredLogger.tssrc/utils/errorMonitoringService.tssrc/components/error/GlobalErrorBoundary.tsxsrc/app/page.tsxsrc/utils/errorHandlingTest.tsERROR_HANDLING_IMPLEMENTATION_SUMMARY.md✅ Verification
This implementation completely addresses the issues described in #24 and provides a robust, production-ready error handling framework that will significantly improve debugging capabilities and developer experience.