Repository navigation
feat(gallery): analytics, keyboard nav, memoization, integration test… - #1313
Merged
nanaf6203-bit merged 1 commit intoOct 21, 2026
Merged
Conversation
|
@fadee26 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
nanaf6203-bit
approved these changes
Oct 21, 2026
nanaf6203-bit
left a comment
nanaf6203-bit
left a comment
Contributor
There was a problem hiding this comment.
Looks good! The keyboard nav and memoization are welcome additions, and glad to see the integration test coverage. Ship it 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#1259 Analytics
src/lib/galleryAnalytics.ts→ gtag +dataLayergallery_view,gallery_thumbnail_click,gallery_lightbox_open/close/navigate,gallery_keyboard_navigate#1258 Keyboard navigation
role="region"/listbox/ focus-visible rings#1257 Re-render optimization
memoonImageGallery/ contentuseCallbackhandlers;useMemothumbnail slicenavigate*asuseCallback#1256 Integration tests
ImageGallery.integration.test.tsx— empty state, analytics, open, keyboard, Escape closegalleryAnalytics.test.tsdocs/GALLERY.mdCloses #1256
Closes #1257
Closes #1259