Repository navigation
feat(gallery): reusable typed gallery - #1314
Merged
nanaf6203-bit merged 1 commit intoOct 21, 2026
Merged
Conversation
Improve Gallery empty-state messaging, apply semantic theme tokens, and add component tests and usage documentation. Closes MettaChain#1260 Closes MettaChain#1261 Closes MettaChain#1262 Closes MettaChain#1263 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@Agaki00 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
nanaf6203-bit
approved these changes
Oct 21, 2026
nanaf6203-bit
left a comment
nanaf6203-bit
left a comment
Contributor
There was a problem hiding this comment.
Nice work on extracting the reusable Gallery — the typed props and shared theme tokens are a solid cleanup. LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1260
Closes #1261
Closes #1262
Closes #1263
Validation
npm test -- --runInBand ImageGallery Gallery— passed (20 tests).npx eslint src/components/gallery/Gallery.tsx src/components/gallery/Gallery.types.ts src/components/gallery/ImageLightbox.tsx src/components/gallery/__tests__/Gallery.test.tsx src/components/property/ImageGallery.tsx src/components/property/ImageLightbox.tsx src/components/property/__tests__/ImageGallery.test.tsx— passed.git diff --cached --check— passed.npm run typecheck— blocked by pre-existing TypeScript errors outside Gallery (for example,src/app/api/errors/route.test.ts).npm run lint— blocked by pre-existing repository-wide lint errors outside Gallery.