Repository navigation
firmware: add Qualcomm Adreno X1-45 and X2-85 microcode - #2
Merged
Merged
Conversation
Import the generic SQE/GMU microcode for Adreno X1-45 (gen71500, chip 0x43030c00) and the SQE/GMU/AQE microcode for Adreno X2-85 (gen80100, chip 0x44070001) from linux-firmware fb0889c0, the commit the catalog already pins. The bytes are unchanged at upstream HEAD. Qualcomm's LICENSE.qcom requires qcom/NOTICE.txt to travel with the binaries, so the catalog gains an optional per-image `notices` list that the verifier checks against the license entries. Mark *.fw as binary so upstream bytes are preserved exactly. OEM- and SoC-signed images (zap shaders, DSP firmware) are excluded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WQApBVbWWFd5kNS1hL3vP9
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the generic Qualcomm Adreno GPU microcode under
qcom/adreno/, following the existing catalog conventions (upstream names, exact bytes, BLAKE3 + size, pinned source, licence entry).0x43030c00gen71500_sqe.fw,gen71500_gmu.bin0x44070001gen80100_sqe.fw,gen80100_gmu.bin,gen80100_aqe.fwProvenance. All files come from linux-firmware
fb0889c0d3dec1e10a9a593a2602e832a752cd2f, the commit the catalog already pins, cited through the samekernelorg-mirrorGitHub mirror. The blobs are identical at canonical upstream HEAD (0147e350, 2026-10-21). Each file's BLAKE3 was checked against both the git blob at the pinned commit and the mirror's raw object.Licensing. WHENCE marks these files "Redistributable. See LICENSE.qcom and qcom/NOTICE.txt". Both texts are copied byte-for-byte to
LICENSES/qcom-adreno.txtandLICENSES/qcom-notice.txt. The terms restrict use to Qualcomm-chipset platforms and forbid reverse engineering.Schema. Since an image now needs a licence and a NOTICE, the catalog gets an optional per-image
notices = [...]list.verify.pyrequires it to be a list of distinct, existing licence entries, and a new test covers a dangling notice. Existing entries and kore'stools/firmware.pyare unaffected.Other changes.
.gitattributesnow marks*.fwbinary, because before this only*.binwas preserved. The README gets a Qualcomm section.Excluded on purpose. Zap shaders (including the generic
x1p42100/gen71500_zap.mbnandglymur/gen80100_zap.mbn) and DSP images are left out. They are TrustZone-authenticated against SoC/OEM keys, so each machine needs its own signed copy. Upstream msm loads only SQE and GMU for X2-85 today, but the AQE image is kept because it is part of that GPU's published set.Test plan
python3 verify.py: verified 160 blobs and 8 licence noticespython3 -m unittest -v test_verify.py: 6 tests passGenerated by Claude Code