Repository navigation
Allow PHP 8-compatible Monolog releases in sample apps - #170
Merged
Merged
Conversation
Document restricted-access use and branch-specific PHP security floors. Allow PHP 8-compatible Monolog 2.x releases so the samples install on patched runtimes.
Contributor
Author
|
@robbieaverill - sorry couldn't tag you as a reviewer, but I thought it'd be useful to get your feedback. |
robbieaverill
left a comment
robbieaverill
left a comment
Contributor
There was a problem hiding this comment.
Hey @TheRealAgentK, I've left a few comments here
TheRealAgentK
changed the title
robbieaverill
approved these changes
Oct 23, 2026
QuantumNightmare
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the Monolog 2.0.2 pin with ^2.1 in both sample applications. Monolog 2.0.2 restricts PHP to ^7.2, preventing installation on PHP 8; the newer 2.x range permits PHP 8-compatible releases without changing the Monolog major version.
Following review feedback, the explicit PHP security-version constraints and README changes have been removed. The net diff is one dependency constraint change in each sample manifest. No SDK-wide support policy or sample application logic changes.
Validation