Repository navigation
ci: stop dependabot proposing updates that cannot install - #296
Open
velocitysystems wants to merge 1 commit into
Open
velocitysystems wants to merge 1 commit into
velocitysystems wants to merge 1 commit into
Conversation
Several open Dependabot PRs fail npm ci or bump one package of a set that has to move together: - `/sdk`: typescript 7 is outside typescript-eslint's range (`<6.1.0`). The Babel and Jest presets are released with react-native, so they are grouped into one PR - `/demo`: react-native 0.88 needs react `^19.3.0` and changes the native projects, so the React Native packages are upgraded by hand. `@react-native/eslint-config` only supports eslint 8 and 9 - `/ExpoDemo`: babel-preset-expo is built on Babel 7. CI builds debug apps, which do not bundle JS, so it cannot catch a Babel 8 break
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop Dependabot from opening PRs that fail
npm ci, or that bump one package of a set that has to move together.Changes
/sdktypescriptmajor versions. chore(deps-dev): bump typescript from 5.9.3 to 7.0.2 in /sdk #288 (5.9 → 7.0.2) failsnpm ci, because typescript-eslint, including the latest 8.72.1, supports TypeScript>=4.8.4 <6.1.0.react-nativeand@react-native/*.@react-native/babel-presetand@react-native/jest-presetare released withreact-native, and chore(deps-dev): bump @react-native/jest-preset from 0.87.1 to 0.88.0 in /sdk #294 would have moved only the Jest preset to 0.88./demoreact,react-test-renderer,react-nativeand@react-native/*. React Native upgrades are done by hand, as in chore: upgrade the sdk's react-native dev toolchain to 0.87 #244, because:react-native0.88 needs react^19.3.0, so chore(deps): bump react-native from 0.87.1 to 0.88.0 in /demo #292 failsnpm ciagainst the demo's react 19.2.3.react-test-renderer19.3.1 needs react^19.3.1.AppDelegate.swift,Info.plistandproject.pbxproj, addsSceneDelegate.swift, and moves react, react-test-renderer and every@react-native/*package together. Dependabot can't make the native changes. This covers chore(deps-dev): bump @react-native/babel-preset from 0.87.1 to 0.88.0 in /demo #285, chore(deps-dev): bump @react-native/jest-preset from 0.87.1 to 0.88.0 in /demo #286, chore(deps-dev): bump @react-native/typescript-config from 0.87.1 to 0.88.0 in /demo #289 and chore(deps): bump react-native from 0.87.1 to 0.88.0 in /demo #292.eslintmajor versions. chore(deps-dev): bump eslint from 8.57.1 to 10.13.0 in /demo #290 (8 → 10) failsnpm ci, because@react-native/eslint-config0.87 and 0.88 support eslint^8 || ^9./ExpoDemo@babel/*major versions. babel-preset-expo 57 depends on Babel 7 plugins, which callapi.assertVersion(7), so they throw under@babel/core8 (chore(deps-dev): bump @babel/core from 7.29.0 to 8.0.9 in /ExpoDemo #287). Expo Demo CI buildsassembleDebugand theDebugconfiguration, which don't bundle JS, so CI would not catch this.After merging
Close #285, #286, #287, #288, #289, #290, #292 and #294. Dependabot opens one grouped PR for the SDK's React Native toolchain on its next run.
Notes
/sdkTypeScript ignore also blocks 6.0, which typescript-eslint does support. Dependabot only proposes the newest version, so without the ignore it would keep proposing 7.ignorealso stops security updates. If it does, a security fix for React or React Native in the demo would need a manual upgrade. Dependabot alerts would still be raised.