Browse and index Minecraft instances offline - #37
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ca18af4e3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Keep debugger compilation runtime-only, report compiler readiness without claiming a disconnect, preserve offline indexing after runtime capture failures, and reuse scan validation on cache hits. Cover all four review findings, changes during cache loading, and order the UI fixture after offline bootstrap.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d37178dee6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Resolve Prism game children before folder-name shortcuts and reject orphaned generated indexes. Track the attempted index source to retire failed local refreshes while preserving runtime handover fallback. Route Retry through project controls, allow immediate retries after failure, and render empty search sources as a terminal state. Took 2 minutes
1 participant
Opening an instance without a saved runtime now exposes its mod archives immediately and builds a local index for code navigation. Saved runtime data takes priority; a runtime announcement replaces the local index.
Instance, Prism,
mods, andtotal-debugselections resolve to the same project. Unrelated folders are rejected without writes, and opening a project no longer creates empty scripts or default state. Local indexes support inspection while runtime-dependent compilation and execution stay unavailable.The decompiler cache scheduling fix is a separate prerequisite commit. Offline discovery covers top-level mod JARs; it does not reconstruct loader transformations or nested dependencies.
Validation: full
:check :localBundlepassed with published dependencies and warnings treated as failures, including all 586 Companion tests. Correctness and code-quality audits are clear after fixes. Light/dark screenshots inspected. Runtime handover is covered with fixtures; no real game launch performed.