Unify source navigation and handle generated Java constructs - #39
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Find Usages could find bytecode members that have no explicit declaration in decompiled Java, then throw when opening them. This replaces the separate navigation, MCP, and debugger lookups with a shared SourceDocument backed by stock Vineflower symbol metadata, JDT structure, and the existing line mappings.
The resolver finds visible occurrences and declarations, maps record accessors and supported lambdas to their source constructs, and falls back to the owning class when provenance is unavailable or ambiguous. Exact MCP member requests and debugger breakpoint validation retain their stricter guarantees.
Constructor usages search the constructor body first, then the current type's instance fields and initializer blocks. Constructors that delegate through this(...) do not search the target constructor's initialization. Static initializers and nested lambda/class bodies remain separate.
Source metadata is prepared on the existing loading workers before publication to Swing and persists with its matching source. Anonymous member identities establish their owning class, and ConstantValue metadata distinguishes constant fields from executable final-field initializers.
Validation:
Code footprint relative to 1.21.1:
Generated record methods, array-constructor helpers without provenance, and other erased or ambiguous constructs retain class fallbacks. This change does not modify Vineflower or include the separate editor-tab work.