Repository navigation
Revert the per-plugin test workflow (#84) - #89
Merged
Merged
Conversation
)" This reverts commit 475a658. The workflow runs each plugin's npm test on a clean macOS runner with Node.js 22 and Git only. The trial (#88) showed plugin tests depend on what is installed: cutline needs FFmpeg, which the runner lacks, and a CI-provided toolset would need its own install, pinning, and maintenance. Plugin authors keep their tests passing on their own machines instead, as CONTRIBUTING already asks them to test the app and report the environment in the pull request. Removes .github/workflows/plugin-tests.yml and the "Plugin tests" sections in CONTRIBUTING (en/zh) and AGENTS.md step 5. Assisted-by: Claude Opus 5.5 (OpenCode)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #84. Plugin authors keep their own tests passing; the repository CI goes back to the rule checks only.
Why
#84 runs every changed plugin's
npm teston a clean macOS runner with Node.js 22 and Git. The trial (#88) showed plugin tests depend on the author's machine:127.0.0.2, which macOS does not configure.Supporting tests like these would mean the maintainers install, pin, and maintain a toolset for plugin authors. That falls outside the review policy in AGENTS.md, which gates on
npm run check, a truthful README, and user-data safety only. CONTRIBUTING already asks authors to test the app and report their environment and results in the pull request.If authors later want CI to run their tests, an opt-in
scripts["test:ci"]is the suggested shape: the author declares that the tests run on a clean runner, and the maintainers provide no tools.Changes
A clean
git revertof 475a658. Nothing has touched these files since:.github/workflows/plugin-tests.yml;CONTRIBUTING.mdandCONTRIBUTING.zh-CN.md;AGENTS.md.Verification
npm run checkpasses (87 tests).Need help on this PR? Tag
@codesmith-botwith what you need.