Repository navigation
Skip drawing while the GL context reports it is lost - #8
Merged
Merged
Conversation
The webglcontextlost event arrives as a separate task, so a frame can still be drawn after the browser has taken the context. If that frame creates the first wrapped texture, twgl's sampler check reads .constructor of the null sampler a lost context returns and throws. draw() now also asks the context itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A production error report showed
null is not an object (evaluating 'Z.constructor')in twgl'screateMIP. The cause:draw()can run after the WebGL context is lost but before thewebglcontextlostevent has arrived. On a lost contextgl.createSampler()returns null, and twgl'sisSamplerreads.constructoron it.isContextLostnow also asksgl.isContextLost()instead of relying only on the event flag, anddraw()uses it.Tests: the new
test/unit/ContextLossTests.jsreproduces the crash with a mock context and fails without the fix. Unit tests,npm run buildand the integration tests pass.Not changed here: the nine "Maximum call stack size exceeded" reports in
penStampcome from one maze project whose custom blocks recurse thousands of levels deep. MistWarp's recursion limit matches TurboWarp's (about 5,455 levels without warp and 8,964 with warp, against 5,457 and 8,967), so the renderer isn't involved.No visible surface.