Repository navigation
Conversation
The `PBXProject` object was split across four partials: `pbxproj_prefix` wrote its start with `attributes` last, and the `TargetAttributes`, `knownRegions`, and `targets` partials were concatenated after it. This put `attributes` after `projectRoot` and `knownRegions` after `attributes`, which isn't the order Xcode writes. `pbxproj_prefix` already runs after `pbxtargetdependencies` and `files_and_groups`, so it now takes those three partials as inputs and writes the whole object in Xcode's order. The final `cat` no longer needs them. Signed-off-by: Ernesto Cambuston <e.cambuston@gmail.com>
…rtial.swift Co-authored-by: Brentley Jones <github@brentleyjones.com> Signed-off-by: Ernesto Cambuston <e.cambuston@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PBXProjectobject is the only one split across partials:pbxproj_prefixwrites its start (withattributeslast), and theTargetAttributes,knownRegions, andtargetspartials are concatenated after it. That putsattributesandknownRegionsout of the order Xcode writes.pbxproj_prefixalready runs afterpbxtargetdependenciesandfiles_and_groups(it readsresolved_repositories_file), so it now takes those three partials as inputs and writes the whole object in Xcode's order:isa,attributes,buildConfigurationList,compatibilityVersion,developmentRegion,hasScannedForEncodings,knownRegions,mainGroup,productRefGroup,projectDirPath,projectRoot,targets. The finalcatno longer takes them.No other change: the final step is still
cat, and the three partials' formats are unchanged. This is a prerequisite for #3375.