Repository navigation
Run the error handler registration test in isolation - #173
Merged
estebanzimanyi merged 1 commit intoOct 11, 2026
Merged
estebanzimanyi merged 1 commit into
estebanzimanyi merged 1 commit into
Conversation
The tests of jmeos-core run concurrently, classes and methods alike (junit-platform.properties), and the binding holds only the latest error handler MEOS receives, in the static field the wrapper of meos_initialize_error_handler fills. ErrorHandlerRegistrationTest registers a handler it keeps no reference to and checks that a collection leaves it reachable, so a handler registered meanwhile, by the other test of the class or by a class such as STBoxTest, replaces the one it checks and leaves that one to the collector. The class is @isolated, as MeosInitializeHandlerTest is, so nothing registers a handler while it runs. Witness: the fork run 38103656194 of JMEOS MobilityDB#172 at 89fd5ee fails ErrorHandlerRegistrationTest.unreferencedHandlerStaysReachable with "the registered handler was collected while MEOS holds it", while the upstream run 38103672322 of the same commit passes it. Measured over MobilityDB 3a8e6dba09 and the catalog of MEOS-API 4baf11705c: three runs of the jmeos-core suite pass 1804 tests each, the two of ErrorHandlerRegistrationTest among them. Why: a test of the binding's handler answers for the binding, not for the order in which the concurrent tests register theirs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests of jmeos-core run concurrently, classes and methods alike (junit-platform.properties),
and the binding holds only the latest error handler MEOS receives, in the static field the wrapper
of meos_initialize_error_handler fills. ErrorHandlerRegistrationTest registers a handler it keeps
no reference to and checks that a collection leaves it reachable, so a handler registered
meanwhile, by the other test of the class or by a class such as STBoxTest, replaces the one it
checks and leaves that one to the collector. The class is @isolated, as MeosInitializeHandlerTest
is, so nothing registers a handler while it runs.
Witness: the fork run 38103656194 of JMEOS #172 at 89fd5ee fails
ErrorHandlerRegistrationTest.unreferencedHandlerStaysReachable with "the registered handler was
collected while MEOS holds it", while the upstream run 38103672322 of the same commit passes it.
Measured over MobilityDB 3a8e6dba09 and the catalog of MEOS-API 4baf11705c: three runs of the
jmeos-core suite pass 1804 tests each, the two of ErrorHandlerRegistrationTest among them.
Why: a test of the binding's handler answers for the binding, not for the order in which the
concurrent tests register theirs.