Repository navigation
docs(nf12): de-duplicate the credits block in the HIP file headers - #3650
Merged
Merged
Conversation
Mirrors dphnAI/nf12#3. Each header stated the same three facts twice: an SPDX copyright line and then 'Copyright (c) 2026 AlpinDale and the nf12 contributors', an SPDX licence identifier and then 'Licensed under the Apache License, Version 2.0', and the dphnAI/nf12 URL both inside the reference-kernel block and one line above it. Three files also repeated the 'written for GPT-QModel (ModelCloud.ai)' sentence that the SPDX line above already makes. Collapse all of that into one three-line credits block that names each party once. Net -28 lines, no content lost. Also fix the gfx1200/gfx1200/gfx1250 typo and retitle the encode section from 'Why the port is not a copy' to 'Port notes'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors dphnAI/nf12#3. Pure cleanup — no code, no behaviour change.
The problem
Every HIP header stated the same three facts twice, and three of them repeated the authorship sentence that the SPDX block already makes:
The fix
One three-line block, each party named exactly once:
Both required credits are preserved — Together AI (NyoomFloat12) and AlpinDale (dphnAI/nf12) — and each file now mentions each of them exactly once.
Also
gfx1200/gfx1200/gfx1250→gfx1200/gfx1201/gfx1250in the format header.Net −28 lines across the five files.
Verification
No functional change, so no perf or accuracy numbers to report.