Repository navigation
feat: Adding support for multiple views per script dynamic tabs - #414
Open
AlexDenfordSkyboxLabs wants to merge 2 commits into
Open
AlexDenfordSkyboxLabs wants to merge 2 commits into
AlexDenfordSkyboxLabs wants to merge 2 commits into
Conversation
| childStringValues.push([child.name, ...valueStrings]); | ||
| } | ||
| } | ||
| childStringValues.push([child.name, ...child.values.map(value => value.toString())]); |
Contributor
Author
There was a problem hiding this comment.
small cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hide whitespace changes to avoid seeing the crazy changes because of formatting.
Few changes needed to make this work
In App.tsx, a dynamic tab now stores an array of descriptors, previously, another descriptor with the same tab name replaced the existing descriptor. Now it is appended to that tabs views, and the rendering loop creates a separate control for each descriptor
I added a 'incrementalUpdates' which is true for scripting tabs where we only send partial update data from native. Whereas before we expected a full set of stats, which would erase the previous data from the other collector/view because the script cases wouldn't necessarily have all stats in each update. WHen incrementalUpdates is true, we ignore missing entries instead of removing them.