Repository navigation
Improve keyboard tasks and pause audio on Escape - #173
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Command entry, sidebar navigation, history and logs could lose useful focus or require extra keyboard traversal. These cleanups preserve drafts and stable selections, provide direct sidebar destinations and a single log selector, and keep history actions usable. Preferences, startup, editor and device recovery now retain useful focus and concise feedback; theme colors and narrow layouts are more readable.
Escape now pauses sounds, pending playback and the shared audio engine while retaining positions and loop progress. The toolbar provides explicit Resume. Incoming voices and virtual MIDI honor pause, including lazy synth setup and queued messages; failed transitions retain recovery.
Each cleanup is a separate commit. The audit and verification notes describe task outcomes and evidence. CI adds native keyboard, pinned axe, real audio-clock and browser zoom checks against the production bundle, plus real Monaco descriptions and marker navigation.
Validation:
npm ci --no-audit --no-fundnpm run typechecknpm testnpm run test:audio-cachenpm run test:a11yActual screen-reader speech, physical MIDI/haptic devices, live voice calls and OS notification delivery were not tested. Automated results cover the documented fixtures and retain incomplete axe checks; they do not establish complete conformance.