Repository navigation
Per-channel reading: the server's channel list, a Channels tab, and a reading rule per channel - #174
Merged
Merged
Conversation
…read aloud
Comm.Channel.List now carries {name, caption, command, kind, listening} and
fills a channels store. Comm.Channel.Start/End mark the output lines that
belong to a channel, so a channel with its own reading rule is spoken once,
from Comm.Channel.Text, in its own voice, and Auto Read leaves its line alone.
Preferences gains a Channels tab (read aloud, voice, notify per channel) and
Alt+Shift+R steps the current buffer's channel through the reading modes.
Stored preferences move to version 2: the unused sayto entry is dropped.
The Channels tab merged each change into the settings it had last rendered, so a mode change followed at once by a voice change lost the mode. It now merges into the stored settings. Found by trying the branch against the live server; the note records that run.
…ship flag Master now tells the output when browser speech has a line, so the screen reader does not announce it too. A channel with its own reading rule sets that flag when its rule speaks the line, and when the rule is Never, so Never is silent for screen-reader users as well. A channel on Same as Auto Read takes master's path unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
The MOO now sends
Comm.Channel.List(at login, on request, and whenever you join or leave a channel) and brackets each channel, say, page and link line withComm.Channel.Start/Comm.Channel.End. This uses both.Comm.Channel.Textas "talker. text" in its voice, and Auto Read skips that channel's output line (the line betweenStartandEnd), so it is neither read twice nor read when set to Never.saytoentry is dropped,say_to_youkeeps its notification by default).Wire
Comm.Channel.Listis[{name, caption, command, kind, listening}].decodeChannelListthrows on any other shape.Tested
tsc --noEmitclean;vitest run: 137 files, 2086 tests pass.src/gmcp/Comm/Channel.test.tsfeeds real telnet bytes.speechSynthesis.speakreplaced by a recorder:Not tested
Known limits
Comm.Channel.Text, so a rule set on them does nothing.say), not its caption (Say).