feat(juce): let an integration append its own client info segment - #30
Merged
Merged
Conversation
ActivationConfig gains a `clientInfo` field, appended to the User-Agent after the module's own `moonbase-juce/<version>` segment rather than replacing it, so a framework built on the module (HISE, a wrapper, a white-label host) can identify itself: moonbase-cpp/4.3.1 moonbase-juce/4.3.1 (JUCE v8.0.4; macOS 15.2) HISE/4.1.0 The SDK now sanitises `client_info` when it builds the header: control characters become spaces, whitespace runs collapse, and the segment is capped at 256 characters. Both shipped transports splice headers into a single line, so a CR/LF in a caller-supplied value could otherwise inject a header. The emptiness check runs after sanitising, so a segment that sanitises away leaves no trailing space.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
github-actions Bot
pushed a commit
that referenced
this pull request
Sep 16, 2026
# [4.4.0](v4.3.1...v4.4.0) (2026-09-16) ### Features * **juce:** let an integration append its own client info segment ([#30](#30)) ([8ced84e](8ced84e))
|
🎉 This PR is included in version 4.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActivationConfiggains aclientInfofield whose value is appended to theUser-Agentafter the module's ownmoonbase-juce/<version>segment rather than replacing it, so a framework built on top of the module (HISE, a wrapper, a white-label host) can identify itself:moonbase-cpp/4.3.1 moonbase-juce/4.3.1 (JUCE v8.0.4; macOS 15.2) HISE/4.1.0. The module's own segment moved into aresolvedClientInfo()helper, matching the existingresolvedX()convention and making it testable without buildinglicensing_options.The core SDK now sanitises
client_infowhen it builds the header (control characters become spaces, whitespace runs collapse, capped at 256 characters), which closes a header-injection path: both shipped transports splice headers into a single line, and the emptiness check now runs after sanitising so a segment that sanitises away leaves no trailing space. Docs cover the new field indocs/juce-module.mdand the module README, andclient_infois now documented indocs/core-sdk.md, where it was missing entirely.Tests: six subcases in
tests/client_tests.cpp(layer ordering, CRLF, embedded NUL, whitespace-only, whitespace collapsing, the cap), two JUCE cases covering the config surface and the value reaching the wire sanitised, and a User-Agent assertion added to the inventory path. Core suite 112/112 and JUCE suite 60/60 pass locally.