Repository navigation
Track packaged files of 100 KB or more with Highlander - #357
Merged
Merged
Conversation
Apply Highlander 0.0.6 to :app with largeFiles enabled at a 100 KB threshold for release, commit its baselines, and run ./gradlew highlander in CI, check.sh and CHECK.md alongside the other guards. Closes #356
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #356.
Applies Highlander 0.0.6 to
:appwithlargeFiles = trueandlargeFilesThresholdKb = 100forrelease. Every packaged file of 100 KB or more (res, assets, jni and Java resources, from the app and its dependencies) is recorded inapp/highlander/releaseLargeFiles.txt. No file reaches 100 KB today, so the baseline holds only the# threshold=100KBheader.The plugin's default duplicate scans (resources and assets) come along with it. Both of their baselines are empty. They are committed because the check fails when a baseline file is missing.
./gradlew highlanderruns in CI afterproguardShieldFast, andcheck.shandCHECK.mdlist it with the other guards. The plugin also hooks intocheck, but neither CI norcheck.shrunscheck.Verification
./gradlew :app:highlanderBaselinegenerates the three baselines, and./gradlew highlanderpasses.app/src/main/assets,:app:highlanderfails with+ assets/highlander-probe.bin: - :app (150 KB). It passes again once the file is removed../gradlew dependencyGuard manifestShield proguardShieldFast moduleRulesandspotlessCheckpass, and the existing baselines are unchanged.