Skip to content

https://github.com/Mu2e/Offline/pull/1960 sub PR #3 - #1964

Open
YongyiBWu wants to merge 2 commits into
Mu2e:mainfrom
YongyiBWu:vdresampler-foundation
Open

https://github.com/Mu2e/Offline/pull/1960 sub PR #3#1964
YongyiBWu wants to merge 2 commits into
Mu2e:mainfrom
YongyiBWu:vdresampler-foundation

Conversation

@YongyiBWu

Copy link
Copy Markdown
Contributor

VDResampler: coordinate transforms, naming, pTotal resampler

@FNALbuild

Copy link
Copy Markdown
Collaborator

Hi @YongyiBWu,
You have proposed changes to files in these packages:

  • MachineLearningTools
  • STMMC

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for 6092751: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild

Copy link
Copy Markdown
Collaborator

☔ The build is failing at 6092751.

scons: *** [build/al9-prof-e29-p106/Offline/tmp/STMMC/src/VDResamplerTrain_module.os] Error 1
scons: *** [build/al9-prof-e29-p106/Offline/tmp/STMMC/src/VDResamplerGenerateFromModel_module.os] Error 1
scons: *** [build/al9-prof-e29-p106/Offline/tmp/STMMC/src/VDResamplerGenerateMix_module.os] Error 1
Test Result Details
test with Command did not list any other PRs to include
merge Merged 6092751 at 9bb1ef2
build (prof) Log file.
ceSimReco 〰️ Log file.
g4test_03MT 〰️ Log file.
transportOnly 〰️ Log file.
POT 〰️ Log file.
g4study 〰️ Log file.
cosmicSimReco 〰️ Log file.
cosmicOffSpill 〰️ Log file.
ceSteps 〰️ Log file.
ceDigi 〰️ Log file.
muDauSteps 〰️ Log file.
ceMix 〰️ Log file.
rootOverlaps 〰️ Log file.
g4surfaceCheck 〰️ Log file.
trigger Log file.
check_cmake 〰️ Log file.
FIXME, TODO TODO (0) FIXME (0) in 5 files
clang-tidy ➡️ 0 errors 90 warnings
whitespace check ➡️ found whitespace errors

N.B. These results were obtained from a build of this Pull Request at 6092751 after being merged into the base branch at 9bb1ef2.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@FNALbuild

Copy link
Copy Markdown
Collaborator

📝 The HEAD of main has changed to f6e4350. Tests are now out of date.

@YongyiBWu

Copy link
Copy Markdown
Contributor Author

The build failed due to mismatches when PR was splitted. Padded intermdiate commit ecbdf8e to allow compilation. These temporary changes are reverted at later sub PRs.

@YongyiBWu

Copy link
Copy Markdown
Contributor Author

@FNALbuild run build test

@FNALbuild

Copy link
Copy Markdown
Collaborator

⌛ The following tests have been triggered for f793077: build (Build queue - API unavailable)

@FNALbuild

Copy link
Copy Markdown
Collaborator

☔ The build is failing at f793077.

scons: *** [build/al9-prof-e29-p106/Offline/tmp/MachineLearningTools/src/ScoreBasedDiffusionModel.os] Error 1
Test Result Details
test with Command did not list any other PRs to include
merge Merged f793077 at f6e4350
build (prof) Log file.
ceSimReco 〰️ Log file.
g4test_03MT 〰️ Log file.
transportOnly 〰️ Log file.
POT 〰️ Log file.
g4study 〰️ Log file.
cosmicSimReco 〰️ Log file.
cosmicOffSpill 〰️ Log file.
ceSteps 〰️ Log file.
ceDigi 〰️ Log file.
muDauSteps 〰️ Log file.
ceMix 〰️ Log file.
rootOverlaps 〰️ Log file.
g4surfaceCheck 〰️ Log file.
trigger Log file.
check_cmake 〰️ Log file.
FIXME, TODO TODO (0) FIXME (0) in 5 files
clang-tidy ➡️ 2 errors 90 warnings
whitespace check ➡️ found whitespace errors

N.B. These results were obtained from a build of this Pull Request at f793077 after being merged into the base branch at f6e4350.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

The new constructor parameters are appended after initializeRandomWeights
rather than placed logically, and SBDMGeneratedSample carries a temporary
conversion to vector<double>, so the VDResampler modules already in the
tree keep compiling against this header. Both are undone by the later PRs
that replace those callers.
@YongyiBWu

Copy link
Copy Markdown
Contributor Author

@FNALbuild run build test

@FNALbuild

Copy link
Copy Markdown
Collaborator

⌛ The following tests have been triggered for 2aafe59: build (Build queue - API unavailable)

@FNALbuild

Copy link
Copy Markdown
Collaborator

☀️ The build tests passed at 2aafe59.

Test Result Details
test with Command did not list any other PRs to include
merge Merged 2aafe59 at f6e4350
build (prof) Log file. Build time: 04 min 22 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
trigger Log file. Return Code 1.
check_cmake Log file.
FIXME, TODO TODO (0) FIXME (0) in 5 files
clang-tidy ➡️ 0 errors 90 warnings
whitespace check ➡️ found whitespace errors

N.B. These results were obtained from a build of this Pull Request at 2aafe59 after being merged into the base branch at f6e4350.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants