https://github.com/Mu2e/Offline/pull/1960 sub PR #7 - #1968
Conversation
|
Hi @YongyiBWu,
which require these tests: build. @Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main. ⌛ The following tests have been triggered for 6420a5d: build (Build queue - API unavailable) |
|
☀️ The build tests passed at 6420a5d.
N.B. These results were obtained from a build of this Pull Request at 6420a5d after being merged into the base branch at f6e4350. For more information, please check the job page here. |
The new constructor parameters are appended after initializeRandomWeights rather than placed logically, and SBDMGeneratedSample carries a temporary conversion to vector<double>, so the VDResampler modules already in the tree keep compiling against this header. Both are undone by the later PRs that replace those callers.
Also restores the logical constructor parameter order: this PR replaces the only caller that constructed a model directly, and the generators construct through loadModel, so nothing depends on the temporary order any more. SBDMGeneratedSample keeps its conversion for the generators.
Also drops the temporary SBDMGeneratedSample vector conversion: every remaining caller takes the struct and picks zscore or value explicitly.
c73c458 to
e31c742
Compare
|
@FNALbuild run build test |
|
⌛ The following tests have been triggered for e31c742: build (Build queue - API unavailable) |
|
☀️ The build tests passed at e31c742.
N.B. These results were obtained from a build of this Pull Request at e31c742 after being merged into the base branch at f6e4350. For more information, please check the job page here. |
VDResampler: standalone plot regeneration for grid jobs