Repository navigation
Preserve wave0 and wave attributes on SpectralGradient indexing and slicing - #458
Closed
DYNOSuprovo wants to merge 1 commit into
Closed
DYNOSuprovo wants to merge 1 commit into
DYNOSuprovo wants to merge 1 commit into
Conversation
|
Thank you for your contribution to sbpy, an Astropy affiliated package! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
There was a problem hiding this comment.
Welcome to sbpy 👋 and congratulations on your first pull request! 🎉
A project member will respond to you as soon as possible; in the meantime, please have a look over the Checklist for Contributed Code at Astropy and make sure you've addressed as many of the questions there as possible and relevant for sbpy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #457
Summary of Changes
__array_finalize__(self, obj)inSpectralGradientto preservewave0andwaveattributes when slicing, indexing, or copying instances.SpectralGradient.__new__, preserve existingwaveandwave0attributes when converting or re-instantiatingSpectralGradientinstances unless explicitly overridden.sbpy/spectroscopy/tests/test_specgrad.pyverifying that scalar indexing, subarray slicing, copying, and re-instantiation preservewave0andwave.CHANGES.rstunderv0.7.0 (unreleased) -> Bug Fixes -> sbpy.spectroscopy.