Repository navigation
perf(deploy): ticket #430 deploy speed — isolated from the CLI split, with review fixes - #441
Merged
Merged
Conversation
|
🚅 Deployed to the everything-dev-pr-441 environment in heartfelt-ambition 9 services not affected by this PR
|
elliotBraem
force-pushed
the
feat/cli-split
branch
from
October 16, 2026 18:34
43c60a8 to
a489645
Compare
elliotBraem
force-pushed
the
feat/deploy-speed
branch
from
October 16, 2026 18:42
3bcf30e to
aa9ddac
Compare
elliotBraem
force-pushed
the
feat/cli-split
branch
from
October 16, 2026 18:51
920b712 to
9b2e7f5
Compare
elliotBraem
force-pushed
the
feat/deploy-speed
branch
from
October 16, 2026 19:52
c4d23f7 to
27358d9
Compare
elliotBraem
changed the base branch from
feat/cli-split
to
feat/deploy-output-polish
October 16, 2026 19:52
…load rejections, build-mode oracle key, probe fallback
elliotBraem
force-pushed
the
feat/deploy-speed
branch
from
October 16, 2026 20:36
27358d9 to
5a45291
Compare
railway-app
Bot
temporarily deployed
to
heartfelt-ambition / everything-dev-pr-441
October 16, 2026 20:44
Destroyed
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket #430 (deploy speed), isolated from #437 per review — the perf commits rode the CLI-split branch unreviewed, and the first perf pass had corrupted
installBundleFetchFromEnv(this branch carries the repair).Stacked on #437 (base
feat/cli-split); retarget tomainonce #437 merges.What lands
contentHashStalenessOracle): sha256 over the member tree + transitive local-dependency hashes + build-mode env, persisted at.bos/build-cache.json; unknown/missing dist/hash mismatch errs toward building;--force-build/BOS_FORCE_BUILD=1retains the blanket force.mapWithConcurrencycapped atmin(concurrency, os.cpus()).onWorkspaceBuilt), bounded by a semaphore (BOS_UPLOAD_CONCURRENCY, default 4); entries assemble in target order — the published config is byte-identical to the serial train's.Review fixes on top (this branch's own commits)
BOS_UPLOAD_CONCURRENCYunder late build completions; extractedcreateSemaphore(release hands the slot to a waiter, count conserved) with deterministic unit tests (upload-semaphore.test.ts: transfer semantics + 200-work churn never exceeds the limit).PublishTrainErrorinstead of discarding it.{ nodeEnv, deploy }frombuild-train), notprocess.env(which never carriesDEPLOYon a normal deploy — the term was decorative and let a dev-built dist judge as deploy-fresh); pinned by a mode-change test inbuild-staleness.test.ts.installBundleFetchFromEnvsignature repaired — the first perf commit dropped the parameter-list close and thenormalizeBundleDirlines; typecheck could not run at the old tip.Test plan
pnpm run typecheck/lint/testat this tip (the perf commits were never verified post-review-fix before; the old tip did not compile)deploy-train-service.test.tsupload-order/ordering/serialization cases unchanged