Telugu TN: Cardinal Semiotic Class

[nharidas]

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Before your PR is "Ready for review"

Pre checks:

• Have you signed your commits? Use git commit -s to sign.
• Do all unittests finish successfully before sending PR?
  1. pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
  2. Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...
• If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
• Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
• Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
• Have you added the correct license header Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
• If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
• Remove import guards (try import: ... except: ...) if not already done.
• If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
• Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

• New Feature
• Bugfix
• Documentation
• Test

If you haven't finished some of the above items you can still open "Draft" PR.

[github-actions]

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

[folivoramanh]

make sure both pytest and sparrowhawk test pass, and fix the problem of blank space

[nharidas]

Thanks for the review. I’ve addressed the comments on this PR.

• Removed Telugu post-processing (no PostProcessingFst for te; tests use post_process=False)
• Dropped custom add_weight; competing *1 forms are split instead of using a -0.2 bias
• Deleted teens_and_ties_thousand.tsv; combining ఒక is composed from ties
• magnitudes.tsv is loaded with load_labels
• Digit/zero classes come from digit.tsv / zero.tsv (no hardcoded NEMO_TE_DIGIT)
• Word tagger simplified to NEMO_NOT_SPACE
• Jenkinsfile: removed the commented TE ITN stage
• Tests: assert pred == expected (no .strip())

pytest for Telugu cardinals is passing. Sparrowhawk tests are still pending; I’ll update this PR once they are run.

[folivoramanh]

• add init file in data/ (currently only in data/numbers/)

[nharidas]

Thanks for the follow-up review.

Changes Made:

• Added nemo_text_processing/text_normalization/te/data/init.py
• Simplified Jenkinsfile to a single L0: TE TN grammars stage (removed the parallel Create TE TN/ITN Grammars wrapper)
• Expanded cardinal tests to cover large magnitudes, including 999999999999999 (15 digits) and up to 19-digit shankh-scale numbers, plus Telugu digits, in-sentence, leading zeros, and negatives
• Negative numbers: verbalizer now outputs “మైనస్” for the sign (Telugu localized form, same pattern as Spanish “menos”), instead of English “minus”. Test cases updated accordingly.

Testing:

• Cardinal pytest test cases passed
• Sparrowhawk “testTNCardinal” passed

Re: Spanish reusable component: replied in the thread with details.

[nharidas]

Thanks for the review.

Changes Made:

• Expanded test_cases_cardinal.txt with internal-zero and separator coverage (Indian and Western grouping)
• Added separator handling in cardinal.py (indian_grouping / western_grouping) to strip commas before normalization
• Moved hardcoded inputs to TSV files.
• Removed unused code in test_sparrowhawk_normalization.sh

Testing:

• Cardinal pytest test cases passed
• Sparrowhawk testTNCardinal passed

[nharidas]

@mgrafu Thanks for the review.

Changes Made:

• Documented max magnitude coverage in the CardinalFst docstring (up to 19 digits / shankh / శంఖ, 10¹⁷; larger values via composed కోటి groups)
• Fixed singular/plural కోటి vs కోట్ల for large numbers.
• Expanded test_cases_cardinal.txt with the suggested large-number, mixed-script, separator, and edge cases
• Updated Jenkins: guarded TE L0 grammar build (when + failFast + parallel) and L1 TE pytest stage with TE_TN_CACHE
• Added word and punctuation unit tests (test_word.py, test_punctuation.py + corresponding test_cases_*.txt)
• Updated test_sparrowhawk_normalization.sh to run word and punctuation Sparrowhawk suites

Testing:

• Cardinal, word, and punctuation pytest cases passed
• Sparrowhawk testTNCardinal, testTNWord, and testTNPunctuation passed

[nharidas]

@mgrafu Thanks for the review.

Changes Made:

• Fixed cardinal edge cases: …01 → ఒక కోటి, X1 లక్షల → ఒక (not ఒకటి), mixed-script leading zeros pass-through
• Renamed arab/kharab/padma/shankh tiers to crore-relative names.
• Fixed FST ambiguity so Sparrowhawk and Pytest agree on large numbers (e.g. 3164010000000)
• Added EN-style word and punctuation tests (Telugu examples), plus punctuation match-input via punct_post_process=True

Testing:

• Cardinal, word, and punctuation pytest cases passed
• Sparrowhawk testTNCardinal, testTNWord, and testTNPunctuation passed

[nharidas]

@mgrafu Thanks for the review.

Changes Made:

• Added these test cases, fixed the related failed readings
• Additionally cleaned up the cardinal grammar by collapsing repeated band wiring into shared helpers (band, oka_count, crore_of, kotlu, oka_koti, etc.).
• Removed the English related test cases from word test cases.

Testing:

• Cardinal, word, and punctuation pytest cases passed
• Sparrowhawk testTNCardinal, testTNWord, and testTNPunctuation passed

[mgrafu]

it looks like we may have a bug -- can you add these and check what happens?

500000010000000~ఐదు కోట్ల ఒక కోటి
5000000010000000~యాభై కోట్ల ఒక కోటి
50000000010000000~ఐదు వందల కోట్ల ఒక కోటి
500000000010000000~ఐదు వేల కోట్ల ఒక కోటి
5000000000010000000~యాభై వేల కోట్ల ఒక కోటి
500000015724739~ఐదు కోట్ల ఒక కోటి యాభై ఏడు లక్షల ఇరవై నాలుగు వేల ఏడు వందల ముప్పై తొమ్మిది
50000000015724739~ఐదు వందల కోట్ల ఒక కోటి యాభై ఏడు లక్షల ఇరవై నాలుగు వేల ఏడు వందల ముప్పై తొమ్మిది
268828015724739~రెండు కోట్ల అరవై ఎనిమిది లక్షల ఎనభై రెండు వేల ఎనిమిది వందల ఒక కోటి యాభై ఏడు లక్షల ఇరవై నాలుగు వేల ఏడు వందల ముప్పై తొమ్మిది
558073012157368~ఐదు కోట్ల యాభై ఎనిమిది లక్షల ఏడు వేల మూడు వందల ఒక కోటి ఇరవై ఒక లక్షల యాభై ఏడు వేల మూడు వందల అరవై ఎనిమిది
6690674013350484~అరవై ఆరు కోట్ల తొంభై లక్షల అరవై ఏడు వేల నాలుగు వందల ఒక కోటి ముప్పై మూడు లక్షల యాభై వేల నాలుగు వందల ఎనభై నాలుగు
500000020000000~ఐదు కోట్ల రెండు కోట్లు
500000110000000~ఐదు కోట్ల పదకొండు కోట్లు
268828025724739~రెండు కోట్ల అరవై ఎనిమిది లక్షల ఎనభై రెండు వేల ఎనిమిది వందల రెండు కోట్ల యాభై ఏడు లక్షల ఇరవై నాలుగు వేల ఏడు వందల ముప్పై తొమ్మిది