Skip to content

ci(trivy): add artifact and PR configuration scans - #3185

Merged
alangou merged 5 commits into
mainfrom
2988-p0-dependencies-and-deployment-expand-dependabot-retain-cargo-deny-use-trivy-only-for-final-images-and-iac-including-helm-defaults-supported-value-profiles-and-the-packaged-chart
Sep 9, 2026
Merged

ci(trivy): add artifact and PR configuration scans#3185
alangou merged 5 commits into
mainfrom
2988-p0-dependencies-and-deployment-expand-dependabot-retain-cargo-deny-use-trivy-only-for-final-images-and-iac-including-helm-defaults-supported-value-profiles-and-the-packaged-chart

Conversation

@alangou

@alangou alangou commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Add Trivy coverage for published release artifacts and a differential pull-request gate for Helm and Dockerfile configuration. The PR check blocks only newly introduced High or Critical findings, so existing security debt remains visible without blocking unrelated changes.

Related Issue

Part of #2988.

Changes

  • Add a reusable workflow for multi-architecture image scans, deployment configuration scans, and packaged OCI Helm chart scans
  • Add a pull-request and merge-group workflow that compares baseline and candidate findings and publishes the stable OpenShell / Trivy Changes result
  • Keep scanner failures distinct from findings and retain JSON, SARIF, summaries, and workflow artifacts
  • Add narrowly path-scoped false-positive exceptions plus Trivy and Helm to the Nix development shell
  • Document release and PR scan behavior, required status configuration, and Gator gate awareness

After this lands and the check has run once, repository administrators must add OpenShell / Trivy Changes to the required checks in the main ruleset.

Testing

  • mise run pre-commit passes
  • Actionlint passes for both Trivy workflows
  • Differential gate cases cover unchanged findings, new High/Critical findings, below-threshold findings, and malformed reports
  • Manual Trivy scans covered repository configuration, the packaged OCI chart, and multi-architecture images
  • Unit tests added/updated (not applicable: CI and shell tooling only)
  • E2E tests added/updated (not applicable: no runtime behavior change)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Signed-off-by: Adrien Langou <alangou@nvidia.com>
@alangou
alangou force-pushed the 2988-p0-dependencies-and-deployment-expand-dependabot-retain-cargo-deny-use-trivy-only-for-final-images-and-iac-including-helm-defaults-supported-value-profiles-and-the-packaged-chart branch from 02274b3 to ee0e27a Compare September 7, 2026 12:13
Signed-off-by: Adrien Langou <alangou@nvidia.com>
Signed-off-by: Adrien Langou <alangou@nvidia.com>
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Signed-off-by: Adrien Langou <alangou@nvidia.com>
Signed-off-by: Adrien Langou <alangou@nvidia.com>
@alangou
alangou added this pull request to the merge queue Sep 9, 2026
Merged via the queue into main with commit 3693b32 Sep 9, 2026
59 checks passed
@alangou
alangou deleted the 2988-p0-dependencies-and-deployment-expand-dependabot-retain-cargo-deny-use-trivy-only-for-final-images-and-iac-including-helm-defaults-supported-value-profiles-and-the-packaged-chart branch September 9, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants