Skip to content

refactor(policy)!: remove NetworkBinary harness field - #3222

Open
varshaprasad96 wants to merge 1 commit into
NVIDIA:mainfrom
varshaprasad96:refactor/3054-remove-networkbinary-harness/varshaprasad96
Open

refactor(policy)!: remove NetworkBinary harness field#3222
varshaprasad96 wants to merge 1 commit into
NVIDIA:mainfrom
varshaprasad96:refactor/3054-remove-networkbinary-harness/varshaprasad96

Conversation

@varshaprasad96

Copy link
Copy Markdown
Contributor

Summary

Remove the deprecated NetworkBinary.harness field before 0.1.0 while preserving advisor-origin provenance at the endpoint/rule boundary.

Related Issue

Closes #3054

Changes

  • Reserve protobuf field number 2 and name harness, update generated Go bindings, and remove runtime, SDK, and profile uses.
  • Reject legacy YAML/profile harness input with migration guidance while retaining protobuf wire compatibility.
  • Move advisor provenance enforcement to gateway-stamped endpoints and keep advisor binaries separated from explicit rules, including rule-name collisions.
  • Migrate legacy stored policy-history provenance without dropping unknown nested wire fields.
  • Update policy architecture, provider profile docs, and 0.1.0 migration notes.

Testing

  • mise run pre-commit
  • cargo test --workspace --exclude openshell-server -q
  • cargo test -p openshell-server --lib -q
  • cargo test -p openshell-supervisor-network --lib -q
  • cargo test -p openshell-sandbox --lib -q
  • mise run go:ci
  • mise run sdk:ts:ci
  • mise run test:python
  • Focused policy/profile/protobuf migration and provenance regressions.
  • mise run e2e:docker — blocked before execution because the local Docker daemon was unreachable.

Checklist

Closes NVIDIA#3054

Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(policy)!: remove deprecated NetworkBinary.harness

1 participant