Fix nvbug6563848: Make tests properly skip on unsupported devices. - #2742
Merged
Conversation
github-actions
Bot
added
the
cuda.bindings
This comment has been minimized.
This comment has been minimized.
rwgk
reviewed
Sep 1, 2026
| new_handle = nvml.device_get_handle_by_uuidv(nvml.UUIDType.ASCII, uuid.encode("ascii")) | ||
| assert new_handle == device | ||
| with subtests.test(device_index=nvml.device_get_index(device)): | ||
| uuid = nvml.device_get_uuid(device) |
Contributor
There was a problem hiding this comment.
I asked codex to generate a fix for the one finding it had. The fix is here:
The finding was:
- Blocking: PR 2742 still leaves two Orin UUID failures unresolved. cuda_bindings/tests/nvml/test_device.py:69 passes a bare 36-character UUID to UUIDV, which requires 40 bytes and raises ValueError; unsupported_before catches neither that nor the observed NotFoundError. The legacy lookup in cuda_bindings/tests/nvml/test_pynvml.py:55 is unchanged and also returns NotFoundError on the target Orin.
rwgk
approved these changes
Sep 1, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.