Add tests for environment helpers - #2935
Closed
abrarshivani wants to merge 1 commit into
Closed
abrarshivani wants to merge 1 commit into
abrarshivani wants to merge 1 commit into
Conversation
Signed-off-by: Abrar Shivani <ashivani@nvidia.com> Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
abrarshivani
requested review from
cdesiniotis,
karthikvetrivel and
rahulait
as code owners
September 19, 2026 00:49
abrarshivani
requested review from
rajathagasthya,
shivamerla and
tariq1890
as code owners
September 19, 2026 00:49
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add focused unit coverage for path-list prepending and environment variable replacement. The cases verify ordering, no-op behavior, and exact key matching so similarly prefixed variables remain untouched.
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
make fmtLink to Devin session: https://nvidia-cloud.devinenterprise.com/sessions/202583d9612e47d987e4d776b7aa9225
Open in Devin Desktop: https://nvidia-cloud.devinenterprise.com/desktop/session/202583d9612e47d987e4d776b7aa9225?variant=devin
Requested by: @abrarshivani