Skip to content

Make the clangd helper target optional and tolerate a missing source #2352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaxFreedomPollard wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make the clangd helper target optional and tolerate a missing source #2352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,14 +655,30 @@ endif()
if(STDEXEC_IS_TOP_LEVEL)
# Integrate with LLVM/clang tooling
include(${CMAKE_CURRENT_SOURCE_DIR}/cmake/clangd_compile_info.cmake)
add_executable(_clangd_helper_file include/._clangd_helper_file.cpp)
target_link_libraries(
_clangd_helper_file
PRIVATE STDEXEC::stdexec
$<TARGET_NAME_IF_EXISTS:STDEXEC::asioexec>
$<TARGET_NAME_IF_EXISTS:STDEXEC::tbbexec>
$<TARGET_NAME_IF_EXISTS:STDEXEC::taskflowexec>
$<TARGET_NAME_IF_EXISTS:STDEXEC::nvexec>)

# The helper translation unit only exists to give clangd a compile command
# for the headers (see the comment at the top of the file). It is not needed
# when stdexec is configured for packaging, and a source tree that went
# through an archive step may not even have it: the leading "._" looks like
# AppleDouble metadata, which macOS tar and friends can strip.
option(STDEXEC_BUILD_CLANGD_HELPER
"Build the helper translation unit that gives clangd compile commands"
ON)
set(stdexec_clangd_helper_file
"${CMAKE_CURRENT_SOURCE_DIR}/include/._clangd_helper_file.cpp")
if(STDEXEC_BUILD_CLANGD_HELPER AND EXISTS "${stdexec_clangd_helper_file}")
add_executable(_clangd_helper_file "${stdexec_clangd_helper_file}")
target_link_libraries(
_clangd_helper_file
PRIVATE STDEXEC::stdexec
$<TARGET_NAME_IF_EXISTS:STDEXEC::asioexec>
$<TARGET_NAME_IF_EXISTS:STDEXEC::tbbexec>
$<TARGET_NAME_IF_EXISTS:STDEXEC::taskflowexec>
$<TARGET_NAME_IF_EXISTS:STDEXEC::nvexec>)
elseif(STDEXEC_BUILD_CLANGD_HELPER)
message(STATUS "stdexec: ${stdexec_clangd_helper_file} is missing, "
"skipping the clangd helper target")
endif()
endif()

# ##############################################################################
Expand Down