Repository navigation
Revert "Add channel back to analytics register (#1262)" - #1263
Merged
kevinherdez merged 1 commit intoOct 26, 2026
Merged
Conversation
This reverts commit 60fb764.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #1262 I added
channelthinking that we needed it to control the Feature Flags properly.Feature Flags target sets of users to determine whether a flag should be on or off through people properties. There is a
channelpeople property that some feature flags use to distinguish between setting a flag on inreleaseorpreview. However, these properties are set through PostHog'sidentitycall and not theregistercall. Theregistercall only sets 'super' event properties that are added to all of the events sent to PostHog. They are not properties used to determine a specific user.With all that in mind, adding
channelback in the last PR is adding the same information in 2 places sincechannelandenvironmentwill map to the same thing and they're both only event properties. There's no reason to have both and based on the new standards that we made to keep AvyApp and AvyWeb consistent, removingchannelis the right call here.Need help on this PR? Tag
@codesmith-botwith what you need.