Repository navigation
Conversation
yuliadub
left a comment
There was a problem hiding this comment.
thank for running through it and updating 🙏 layout looks good to me!
kevinherdez
left a comment
There was a problem hiding this comment.
Thanks for this! I think it looks good. There's a couple things that I'm going to tweak when I get the PR out for Expo 58 since some of the commands will change slightly, but other than that this is great
Perfect. I'll just leave this open and let you update once you get that merged if that sounds good to you? |
Yeah sounds good! |
I ran into issues following the current docs to run the app locally. Very much open to critique about the layout of docs that I chose here.
Summary
Avy can't run in Expo Go because
@rnmapbox/mapsis a native module, butyarn startforced Expo Go (--go) and the docs never explained development builds.This PR adds a local development guide (getting started first, then an optional deeper dive) and a debugging guide, keeps CONTRIBUTING about contributing, and fixes the instructions that were wrong.
Corrections to the old docs:
.env" is false. The app crashes onMapbox.setAccessTokenat startup.LOG_NETWORK: no code reads it anymore. Network logging comes fromLOG_LEVEL=debug, andtraceadds request and response bodies.MAPBOX_API_KEY, the only key needed locally. Mapbox no longer requires a secret download token.Evidence
yarn start→iopens Expo Go → the app fails at startup because the native Mapbox module is missing.After: from a clean
npx expo prebuild --clean, both platforms reach the onboarding screen:npx expo run:iosbuilds, installs on the iPhone 17 simulator and loads the app with Metro (Build Succeeded, 0 errors).npx expo run:androidinstalls on a Pixel emulator and loads the app.configureCMakeDebug[arm64-v8a] > WARNING: A restricted method in java.lang.System has been called,BUILD FAILED.Android after: JDK 21 (Android Studio's):
BUILD SUCCESSFUL.Follow-ups
exp+avalanche-forecastscheme (iOS has it). Metro warns "Could not find a shared URI scheme", and Android opens to the dev launcher instead of auto-loading the app. The local development doc notes the workaround: tap the running server.Need help on this PR? Tag
@codesmith-botwith what you need.