Repository navigation
Upgrade to Expo 58 - #1271
Open
kevinherdez wants to merge 1 commit into
Open
Upgrade to Expo 58#1271kevinherdez wants to merge 1 commit into
kevinherdez wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the repo to Expo 58. With Expo 58, we're upgrading to RN 0.88 and most of the changes stem from changes in type declarations
Big Changes
View types in RN are now functional components
In RN 0.88 view types are now functional components. This means that the views themselves can no longer be used with
useRef. Instead, the built in types now come with an*Instanceinstance type that can be passed to the refs. For example,ScollViewhas aScrollViewInstancethat's used to pass to theuseRef.As lot of changes are adding the necessary types.
Image.resolveAssetSource->resolveAssetSourceImage.resolveAssetSourcecan now beundefined. A new helper,resolveAssetSource, and type,BundledAssetSourcewere added so that fetching and unwrapping our assets happens in 1 place. This ensures that assets that we reference in code always have the properties we expect and the individual call sites don't need to worry about unwrappingDeliberate Package Changes
This PR changes a few packages either through upgrades or replacing unmaintained packages
@rnmapbox/mapsupgraded to10.3.11. This fixed a crash in the new Exporeact-native-render-htmlwas replaced with@html-native/renderreact-native-render-htmlis no longer maintained@expo/vector-iconswas replaced withreact-native-vector-icons@expo/ui@react-native-segmented-control/segmented-control. However, this is a modern UI package from expo that has a lot of built in SwiftUI (iOS)/Jetpack Compose (Android) native components that could be worthwhile to slowly migrate toUI Changes
On Android, there's a big UI change with the segmented control now that it's using a native, material UI style, component.
Other Changes
The remaining changes fix either deprecated code or make changes to syntax based on upgrades in the package
Need help on this PR? Tag
@codesmith-botwith what you need.