Skip to content

fix: an outdated comment can be replied to and resolved again - #115

Draft
fiddur wants to merge 3 commits into
developfrom
fix/outdated-thread-controls
Draft

fiddur wants to merge 3 commits into
developfrom
fix/outdated-thread-controls

Conversation

@fiddur

@fiddur fiddur commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

OrphanedThreads built its ThreadCard without onReply, onResolve or onUnresolve, and ThreadCard gates the composer and the resolve button on exactly those. So a thread whose lines left the diff lost its conversation at the point it was most needed — the reviewer could not reply "still applies, see line 40", nor resolve it as handled.

It now takes the same commentActions its in-diff sibling and GeneralComments already take, which also drops a prop at both call sites.

Ask and Act stay off: a stale anchor is a poor thing to hand an agent, and #81 does not ask for it.

Closes #81

🤖 Generated with Claude Code

https://claude.ai/code/session_01Bwp5QefjsjMFeq6CK6cT6w

fiddur and others added 3 commits September 15, 2026 15:03
A thread whose lines have left the diff renders in the outdated list, which
built its card without reply, resolve or reopen — the moment a conversation
about it is most useful is the moment it was stranded.

The list now takes the same `commentActions` its in-diff sibling uses, so an
outdated thread carries the controls every other thread has.

Closes #81

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Bwp5QefjsjMFeq6CK6cT6w
…e test

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Bwp5QefjsjMFeq6CK6cT6w
userEvent's per-keystroke delay put the reply case over the 5s timeout on
the node 22.13 runner.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Bwp5QefjsjMFeq6CK6cT6w
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Outdated threads hide reply/resolve, so you can't respond to them

1 participant