Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #18 (publication/request lifecycle), #19 (fixed-batch GRPO and optimizer correctness), and #20 (EHP resource lifecycle). Please review and merge the replacement series in that order. This PR is closed without merging.
Weight reloads must wait for admitted requests and service reservations, then verify installation on every physical TP worker before reopening. Reject partial or stale receipts, preserve snapshot/revision and service-incarnation identities across restart, and require prefix-cache invalidation after changing weights.
Preserve
timeout=0as unlimited waiting and transfer TCPStore listener ownership so cleanup does not close the same socket twice. Register the serving helpers in the installed package and include the HTTP lifecycle test dependency in CPU CI.This PR covers publication and request lifecycle. CPU-offload/NIXL cached-KV migration changes have been removed. The existing lease API remains because it also protects a version-checked request between reservation and dispatch.
Validation: