Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #18 (publication/request lifecycle), #19 (fixed-batch GRPO and optimizer correctness), and #20 (EHP resource lifecycle). Please review and merge the replacement series in that order. This PR is closed without merging.
Depends on #14. This branch includes its planner fix; after #14 merges, the remaining diff covers elastic training.
Elastic Hybrid replicas share the configured global batch with Core replicas. Partition complete GRPO groups across live replicas, weight gradients by their sample counts, and reject stale or duplicate deliveries. Borrowing a GPU changes who computes the batch, not how many samples the optimizer consumes.
Select the Core TP/DP layout at startup and keep it fixed during training. EHP borrowing and return, rollout repartition, GRP decisions, live optimizer-state transfer, and rollout publication remain active. Online Core TP/DP rebuilds are excluded.
Preserve model parameters, FP32 master weights, Adam moments, and independent per-parameter steps during borrowing and return. Check readiness and process ownership before changing resource roles. Count the physical GPUs stopped with a whole rollout engine against the rollout reserve, and start Hybrid replicas only from confirmed complete GPU allocations on one host. An unsuitable engine partition records a capacity shortfall while preserving its serving processes and existing Hybrid replicas.
Bound gradient reduction temporaries, own asynchronous CPU gradient snapshots, and use per-parameter temporaries for automatically selected native Torch Adam foreach behavior while retaining explicit choices and fused optimizers.
Validation: