Repository navigation
fix(compliance): calculate accurate preserved record counts in erasure preview and execution - #719
Open
TochukwuJustice wants to merge 5 commits into
Open
TochukwuJustice wants to merge 5 commits into
TochukwuJustice wants to merge 5 commits into
Conversation
…review and execute (Neurowealth#683)
|
@TochukwuJustice Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #683
Summary of Changes
previewErasure): Replaced hardcoded zero values inpreservedRecordswith live counts querying:adminAuditLogs: Matches logs wheretarget = userIdordetails.userId = userIdvia an indexedORclause.referralConversionsAsOwner: Counts conversions associated with referral codes owned byuserId(referralCode.ownerUserId).referralConversionsAsReferred: Counts conversions where the user was the referred party (referredUserId = userId).executeErasure: Relocated preserved-record counting beforetx.user.delete(...)inside the transaction. This prevents PostgreSQL cascade deletion onReferralCodeandReferralConversionfrom removing records prior to aggregation, ensuring execution metrics match dry-run preview metrics.Promise.resolve(0)stubs inexecuteErasurewith real counting queries.tests/unit/compliance/privacyErasure.test.tswith mocks and assertions verifying exactpreservedRecordscounts and query parameters for preview and execution.referralConversionmock totests/integration/privacy-erasure.integration.test.tsto ensure lifecycle tests pass.Reason for the Changes
Issue #683: When compliance operators inspect erasure impact via
POST /api/admin/erasure/requests/:id/preview(or execution dry runs),previewErasurereturned hardcoded zeroes for preserved records (adminAuditLogs,referralConversionsAsOwner,referralConversionsAsReferred), andexecuteErasureusedPromise.resolve(0)stubs for referral metrics. This produced systematically inaccurate impact assessments prior to approving irreversible deletion.