Repository navigation
fix: multisig transaction signature assembly and log PII scrubbing (#666, #667) - #727
Merged
Abidoyesimze merged 2 commits intoOct 23, 2026
Conversation
…multisig transaction signature assembly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #666 and #667.
Summary of Changes
Issue #667: Multisig
assembleTransactiondiscards collected signaturesassembleTransactioninsrc/stellar/multisig.tswas ignoringenvelope.signaturesand returning an unsigned base transaction, leading to on-chain failures for READY multisig envelopes.decodeDecoratedSignature()to parse collected signatures from XDR base64 strings,{ publicKey, signature },{ hint, signature }, orpublicKey:signatureformats into validxdr.DecoratedSignatureobjects.assembleTransaction()to validate envelope status (READY), non-expired validity, and threshold satisfaction.tests/unit/stellar/multisig.test.tscovering two-signer envelope fixtures, Ed25519 cryptographic verification against real Stellar keypairs, signature deduplication, and error conditions.Issue #666: Structured logs emit PII without scrubbing
scrubPayload()and Winston format transformscrubFormat()placed at root level and transport level so log sampling and debug modes cannot bypass scrubbing.password,secret,token,authorization,cookie,apiKey,bearer, etc.)./24subnet telemetry) and IPv6, Stellar public keys (G...truncated to first/last 4), Stellar secret keys (S...fully redacted), EVM addresses (0x...truncated to first/last 4), and Stripe/Slack/Bearer tokens.docs/OBSERVABILITY.mdand updateddocs/DATA_RETENTION_POLICY.md.tests/unit/utils/logger.test.tsvalidating PII scrubbing across strings, objects, circular references, child loggers, and raw log fixture output.CI & Hygiene Verification
npm run typecheckpasses with 0 errors).npm run lintpasses with 0 errors).Closes #666
Closes #667