Repository navigation
Add the shell identification tables - #159
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 7 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014gSmkTwxzaQZAz7pgbZjPF
erwan-joly
force-pushed
the
claude/project-thread-mqsz4u
branch
from
November 6, 2026 13:06
4609f4e to
8413fb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Erwan · project thread
Adds
IShellService/ShellService, which NosCore needs to identify shells (NosCoreIO/NosCore#816):GetSlots(ShellType, rarity): the option levels a shell of that kind and rarity rolls, in order. Each slot is either guaranteed or rolls half of the time.GetWeaponOptions(level)/GetArmorOptions(level): for option levels 1-12 (normal, special and PvP groups ranked C/B/A/S), the options that can roll and their per-mille range.GetValue(perMille, shellLevel): the option value. It scales with the shell level, which is floored at 30, and is never below 1. Flag options such as "undisturbed when casting" have a range of 0 and so always come out as 1.GetIdentificationCost(shellLevel, rarity): the Rainbow Pearl count, level / 10 + rarity.The whole table is in
documentation/DocumentationTest.ShellDocumentation.approved.md. Bumps NosCore.Shared to 6.2.0 for the shell enums.Generated by Claude Code