Skip to content

Add equipment +13, SP +20, SP points past 410 and the low-level EXP boost - #161

Merged
erwan-joly merged 1 commit into
masterfrom
claude/project-thread-8i5x5z
Nov 6, 2026
Merged

erwan-joly merged 1 commit into
masterfrom
claude/project-thread-8i5x5z

Conversation

@erwan-joly

@erwan-joly erwan-joly commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Equipment upgrade runs to +13: +10 to +11 succeeds 0.5 %, then 0.4 % and 0.2 %, each with 0.5 % fixed. These levels cost 1.25M / 1.6M / 2M gold, 1200 / 1500 / 2000 Cella Powder, 4 / 6 / 8 Pulverised Dimensional Force and 1 / 2 / 3 Dimensiolith Shards. Every miss from +10 on fills a pity gauge by the success chance, out of 1000. GetGemType replaces UsesCompleteGem (Soul Gem, Complete Soul Gem, Dimensional Force).
  • SP upgrade runs to +20: success 1.2 / 1 / 0.8 / 0.6 / 0.4 %, soul destroyed 70 / 70 / 75 / 80 / 80 %, gold 1.25M to 2.25M, 80 to 120 feathers, 32 to 40 full moons, 2 to 10 Dragon Gems instead of souls, and 1 / 1 / 2 / 2 / 3 Dimensiolith Shards for the cards of the other dimensions.
  • SP points: +16 to +20 add 188 / 203 / 218 / 233 / 249 points. A stat can reach 105 / 110 / 115 / 120 / 120, costing 3 points per level to 105, 4 to 119 and 5 for 120. The bonus curves and milestones continue to level 120.
  • Group EXP: every member gets 75 % of the kill in a group of two and 70 % in a group of three, for both experience and job experience.
  • Low-level boost (new ILowLevelBoostService): experience x3 to level 5 and x2 to 18, job experience x3 to level 12 and x2 to 20, from the character's level.

The equipment and SP odds and costs match the tables compiled into the current client. Removing UsesCompleteGem is a breaking change, so this is 5.0.0.

Tests

dotnet test: 33 passed, with approval tables regenerated for every changed service.

🤖 Generated with Claude Code

https://claude.ai/code/session_014gSmkUgtue8mHJ8prh9NdK

…ow-level EXP boost

- Equipment upgrades run to +13. From +10 they take Pulverised Dimensional Force and
  Dimensiolith Shards, and every miss fills a pity gauge by the success chance, out of 1000.
  The gem is now a GetGemType value, replacing UsesCompleteGem.
- Specialist card upgrades run to +20. From +15 they take Dragon Gems instead of souls, and
  the cards of the other dimensions also take Dimensiolith Shards.
- Cards past +15 earn up to 486 points, and each stat can go past level 100 to 120.
- Members of a group of two get 75% of the kill's experience and job experience each, 70% in
  a group of three.
- Characters up to level 18 get double or triple experience, and up to level 20 double or
  triple job experience.

Removing UsesCompleteGem is a breaking change, hence 5.0.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014gSmkUgtue8mHJ8prh9NdK
@coderabbitai

coderabbitai Bot commented Nov 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 30 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between d2ffeea and c84b32d.

Files selected for processing: 18

  • documentation/DocumentationTest.EquipmentUpgradeDocumentation.approved.md
  • documentation/DocumentationTest.ExperienceShareDocumentation.approved.md
  • documentation/DocumentationTest.LowLevelBoostDocumentation.approved.md
  • documentation/DocumentationTest.SpUpgradeDocumentation.approved.md
  • documentation/DocumentationTest.SpecialistPointDocumentation.approved.md
  • src/NosCore.Algorithm/Constants.cs
  • src/NosCore.Algorithm/EquipmentUpgradeService/EquipmentUpgradeService.cs
  • src/NosCore.Algorithm/EquipmentUpgradeService/IEquipmentUpgradeService.cs
  • src/NosCore.Algorithm/EquipmentUpgradeService/UpgradeGemType.cs
  • src/NosCore.Algorithm/ExperienceShareService/ExperienceShareService.cs
  • src/NosCore.Algorithm/LowLevelBoostService/ILowLevelBoostService.cs
  • src/NosCore.Algorithm/LowLevelBoostService/LowLevelBoostService.cs
  • src/NosCore.Algorithm/NosCore.Algorithm.csproj
  • src/NosCore.Algorithm/SpUpgradeService/ISpUpgradeService.cs
  • src/NosCore.Algorithm/SpUpgradeService/SpUpgradeService.cs
  • src/NosCore.Algorithm/SpecialistPointService/ISpecialistPointService.cs
  • src/NosCore.Algorithm/SpecialistPointService/SpecialistPointService.cs
  • test/NosCore.Algorithm.Tests/DocumentationTest.cs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@erwan-joly
erwan-joly merged commit 6383125 into master Nov 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants