[erwan-joly]

Part of #2718

Since #2740, TickAsync sends the icon removal itself. The interface comment still told callers to send BfePacket for the expired buffs, which would now mean sending the removal twice. This PR is that one comment line, nothing else.

---

Generated by Claude Code

Summary by CodeRabbit

• Documentation
  • Clarified that expired buffs are removed and their icons are cleared during buff ticking. This is a documentation update only; it does not change gameplay behavior.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

This pull request updates the IBuffService.TickAsync comment. The comment now states that the method drops expired buffs and removes their icons. It removes the earlier note about timer-driven handlers using the returned list.

Changes

Buff tick documentation

Layer / File(s)	Summary
TickAsync comment clarification src/NosCore.GameObject/Services/BattleService/IBuffService.cs	The TickAsync comment now says the method removes expired buffs and their icons. It no longer describes timer-driven handlers using the returned list to avoid re-querying.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Possibly related issues

• Expired buff leaves a greyed icon in the client #2718: The issue describes buff expiry packet handling and client icon state, which matches the updated TickAsync comment.

Possibly related PRs

• NosCoreIO/NosCore#2740: This PR changes TickAsync to remove expired buff icons, and this pull request updates the comment to match that behavior.
• NosCoreIO/NosCore#2701: This PR adds buff icon removal with a zero-duration packet on death, which is the packet behavior referenced by the updated comment.
• NosCoreIO/NosCore#2686: This PR tests buff expiry through the buff tick path that the updated comment describes.

Suggested reviewers: claude

Merge Risk: Minimal · up to 612aa

The change clarifies buff icon removal. No merge-blocking risk is identified.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly describes the removal of the stale bf_e note from IBuffService.TickAsync, which is the pull request’s main change.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

Recent review info

Run configuration

• Source mode: Auto
• Repository: NosCoreIO/NosCore
• Branch: claude/buff-doc-comment
• File: .coderabbit.yaml
• Commit: 612aa2c
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 10019fd7-2aed-432f-8f34-67fb7f604b10

Commits

Reviewing files that changed from the base of the PR and between 472ef8d and 612aa2c.

Files selected for processing: 1

• src/NosCore.GameObject/Services/BattleService/IBuffService.cs

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.